Skip to content

Add TLS scanner job to csi-operator for AWS EBS - #82134

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
RomanBednar:feat/aws-ebs-tls-scanner
Jul 21, 2026
Merged

Add TLS scanner job to csi-operator for AWS EBS#82134
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
RomanBednar:feat/aws-ebs-tls-scanner

Conversation

@RomanBednar

@RomanBednar RomanBednar commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add optional, manually-triggered TLS scanner presubmit job (tls-scanner-aws-ebs) to csi-operator for main, release-4.23, release-5.0, and release-5.1

Summary by CodeRabbit

Adds an optional, manually triggered tls-scanner-aws-ebs presubmit job to the csi-operator CI configuration for main, release-4.23, release-5.0, and release-5.1. The job uses the tls-scanner-tool base image and reuses the openshift-e2e-aws-csi workflow to run tls-scanner-run against the openshift-cluster-csi-drivers namespace on the openshift-org-aws cluster profile (with OLM-related dependencies/env vars omitted since AWS EBS CSI is platform-built). It is invoked via /test tls-scanner-aws-ebs, and job definitions are generated via make jobs.

Rehearsal runs were requested for the TLS scanner job(s) on main, release-4.23, and release-5.0, including both the driver-specific tls-scanner-aws-ebs name and the shorter tls-scanner variant.

@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

Walkthrough

CSI operator CI configurations add the tls-scanner-tool base image and an optional AWS EBS E2E test running tls-scanner-run against the CSI driver namespace.

Changes

TLS scanner CI integration

Layer / File(s) Summary
Declare TLS scanner image
ci-operator/config/openshift/csi-operator/*.yaml
Adds the tls-scanner-tool base image with its image name, namespace, and tag across main and release configurations.
Wire optional AWS scanner test
ci-operator/config/openshift/csi-operator/*.yaml
Adds the optional tls-scanner-aws-ebs test using openshift-org-aws, scanner resource settings, SCAN_NAMESPACE=openshift-cluster-csi-drivers, the tls-scanner-run reference, and the openshift-e2e-aws-csi workflow.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • openshift/release#82125: Adds the same TLS scanner image and optional test wiring in related CSI operator CI configurations.
  • openshift/release#82133: Adds the same TLS scanner image and AWS E2E test configuration in another operator configuration.

Suggested labels: approved

Suggested reviewers: jsafrane, tsmetana

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Only ci-operator/job YAML changed; I found no Ginkgo It/Describe/Context/When titles or any dynamic test identifiers.
Test Structure And Quality ✅ Passed PR only changes ci-operator YAML job configs; no Ginkgo test code or It/BeforeEach/Eventually logic is in scope.
Microshift Test Compatibility ✅ Passed Only ci-operator/job YAML changed; no new Ginkgo test code or MicroShift-incompatible API/resource usage was added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No new Ginkgo e2e tests were added; the job only wires tls-scanner-run into an existing AWS CSI workflow and adds no node-count/HA assumptions.
Topology-Aware Scheduling Compatibility ✅ Passed Only ci-operator/job configs changed; the new tls-scanner job adds image refs and test metadata, with no nodeSelector/affinity/topology spread or topology-aware scheduling logic.
Ote Binary Stdout Contract ✅ Passed PR only changes ci-operator YAML configs; no OTE binary source or suite setup code was modified, so the stdout contract isn’t implicated.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Only CI config/step refs were added; no new Ginkgo tests or IPv4/public-internet assumptions were introduced.
No-Weak-Crypto ✅ Passed Touched csi-operator files are YAML job/config definitions only; targeted scan found no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB or custom-crypto code.
Container-Privileges ✅ Passed No privilege-related fields were added in the changed csi-operator configs or generated presubmit jobs.
No-Sensitive-Data-In-Logs ✅ Passed No passwords/tokens/PII/internal-hostnames were added; the new tls-scanner config only sets image refs, namespace, CPU/memory, and workflow names.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: adding a new TLS scanner job for csi-operator on AWS EBS.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2026
@openshift-ci
openshift-ci Bot requested review from jsafrane and tsmetana July 20, 2026 08:06
@RomanBednar

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-csi-operator-main-tls-scanner-aws-ebs

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@RomanBednar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@RomanBednar

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-csi-operator-release-4.23-tls-scanner-aws-ebs

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@RomanBednar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@RomanBednar

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-csi-operator-main-tls-scanner-aws-ebs

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@RomanBednar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@RomanBednar

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-csi-operator-main-tls-scanner

@RomanBednar

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-csi-operator-release-4.23-tls-scanner

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@RomanBednar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

1 similar comment
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@RomanBednar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@RomanBednar

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-csi-operator-release-5.0-tls-scanner

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@RomanBednar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@RomanBednar

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-csi-operator-release-5.0-tls-scanner

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@RomanBednar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@RomanBednar

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-csi-operator-release-4.23-tls-scanner

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@RomanBednar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@RomanBednar

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-csi-operator-main-tls-scanner

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@RomanBednar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@RomanBednar
RomanBednar force-pushed the feat/aws-ebs-tls-scanner branch from c27b495 to 0dc6848 Compare July 20, 2026 14:30
@openshift-ci openshift-ci Bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2026
Add an optional, manually-triggered TLS scanner presubmit job
(tls-scanner-aws-ebs) to the csi-operator CI configuration for main,
release-4.23, release-5.0, and release-5.1 branches.

The job reuses the openshift-e2e-aws-csi workflow to provision an AWS
cluster with the built-in EBS CSI driver, then overrides the test phase
to run tls-scanner-run against the openshift-cluster-csi-drivers
namespace. Scanner resources are set to 1 CPU / 1Gi to fit CI cluster
node capacity. Triggered via `/test tls-scanner-aws-ebs`.
@RomanBednar
RomanBednar force-pushed the feat/aws-ebs-tls-scanner branch from 0dc6848 to e26da2d Compare July 20, 2026 14:36
@RomanBednar

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-csi-operator-release-4.23-tls-scanner-aws-ebs pull-ci-openshift-csi-operator-main-tls-scanner-aws-ebs

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@RomanBednar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@RomanBednar: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-csi-operator-main-tls-scanner-aws-ebs openshift/csi-operator presubmit Presubmit changed
pull-ci-openshift-csi-operator-release-4.23-tls-scanner-aws-ebs openshift/csi-operator presubmit Presubmit changed
pull-ci-openshift-csi-operator-release-5.0-tls-scanner-aws-ebs openshift/csi-operator presubmit Presubmit changed
pull-ci-openshift-csi-operator-release-5.1-tls-scanner-aws-ebs openshift/csi-operator presubmit Presubmit changed
pull-ci-openshift-csi-operator-release-5.1-aws-efs-cross-account-operator-e2e openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-5.1-aws-efs-operator-e2e openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-5.1-aws-efs-operator-e2e-extended openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-5.1-aws-efs-single-zone-cross-account-operator-e2e openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-5.1-aws-efs-single-zone-operator-e2e openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-5.1-aws-efs-single-zone-operator-e2e-extended openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-5.1-aws-efs-sts-cross-account-operator-e2e openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-5.1-ci-index-aws-efs-csi-driver-operator-bundle openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-5.1-ci-index-smb-csi-driver-operator-bundle openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-5.1-e2e-aws-csi openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-5.1-e2e-aws-csi-extended openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-5.1-e2e-aws-eusc-techpreview-csi openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-5.1-e2e-aws-ovn-upgrade openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-5.1-e2e-azure openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-5.1-e2e-azure-csi openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-5.1-e2e-azure-csi-extended openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-5.1-e2e-azure-csi-hypershift openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-5.1-e2e-azure-csi-volumeattributesclass openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-5.1-e2e-azure-file-csi openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-5.1-e2e-azure-file-csi-extended openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-5.1-e2e-azure-file-csi-hypershift openshift/csi-operator presubmit Ci-operator config changed

A total of 224 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@RomanBednar

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-csi-operator-release-4.23-tls-scanner-aws-ebs

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@RomanBednar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@RomanBednar

Copy link
Copy Markdown
Contributor Author

/retest

@rhrmo

rhrmo commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2026
@openshift-ci

openshift-ci Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhrmo, RomanBednar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

@RomanBednar: The label(s) /label rehearsals-ack cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, ux-approved, no-qe, rebase/manual, cluster-config-api-changed, run-integration-tests, verified, ready-for-human-review, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/skip-dependent-bug-check, jira/valid-bug, ok-to-test, priority/ci-critical, stability-fix-approved, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

Details

In response to this:

/label rehearsals-ack

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@RomanBednar

Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@RomanBednar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 21, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@RomanBednar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 1378dad into openshift:main Jul 21, 2026
18 checks passed
RomanBednar added a commit to RomanBednar/release that referenced this pull request Jul 22, 2026
Add TLS_13_ENABLE_TLS_ADHERENCE, TLS_13_TLS_ADHERENCE_POLICY env vars
and tls-13 step ref to tls-scanner-aws-ebs test in csi-operator configs
for main, release-4.23, release-5.0, and release-5.1.

This follows the pattern established in PR openshift#81917 for GCP Filestore
and is a followup to PR openshift#82134 which added the base TLS scanner test.
fracappa pushed a commit to fracappa/release that referenced this pull request Jul 22, 2026
Add an optional, manually-triggered TLS scanner presubmit job
(tls-scanner-aws-ebs) to the csi-operator CI configuration for main,
release-4.23, release-5.0, and release-5.1 branches.

The job reuses the openshift-e2e-aws-csi workflow to provision an AWS
cluster with the built-in EBS CSI driver, then overrides the test phase
to run tls-scanner-run against the openshift-cluster-csi-drivers
namespace. Scanner resources are set to 1 CPU / 1Gi to fit CI cluster
node capacity. Triggered via `/test tls-scanner-aws-ebs`.
RomanBednar added a commit to RomanBednar/release that referenced this pull request Jul 29, 2026
Add TLS_13_ENABLE_TLS_ADHERENCE, TLS_13_TLS_ADHERENCE_POLICY env vars
and tls-13 step ref to tls-scanner-aws-ebs test in csi-operator configs
for main, release-4.23, release-5.0, and release-5.1.

This follows the pattern established in PR openshift#81917 for GCP Filestore
and is a followup to PR openshift#82134 which added the base TLS scanner test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants